ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

LDAP is unavailable app crash (Bug #953)

Added by Robert Mitwicki at 2012-03-26 07:27 am. Updated at 2012-06-08 10:02 am.

Status:Open Start date:2012-03-26
Priority:Normal Due date:
Assignee:Robert Mitwicki % Done:

0%
Category:-
Target version:-
Remote issue URL: Affected version:master

Description

What steps will reproduce the problem?
1. Setup LDAP authorization
2. Turn down LDAP server
3. Try login using account with LDAP authorization

What is the expected output? What do you see instead?
It should inform user about that authorization source is unavailable at the moment.
But instead of that it just crash and give 500 to user.

History

#1
Updated by Robert Mitwicki at 2012-03-27 12:47 pm

I made some improvements in LDAP support, especial with test LDAP authorization.
But main thing is right now CP not crash when LDAP is offline and user will get info about that.

  • Status changed from Open to Ready for review

#3
Updated by Felix Schäfer at 2012-06-07 02:28 pm

Hello Robert,

I had a look at your pull request and I have one major problem with it: the return value of methods should not be changed and errors shouldn't be passed as return values.

The "better" ruby way would be to define a new error class, throw that where the error occurs and catch it where you want to catch it. Have a look at source:/app/models/mail_handler.rb#L19 for an example (probably not a good one, but you should get the idea).

  • Status changed from Ready for review to Open

#4
Updated by Robert Mitwicki at 2012-06-08 10:02 am

Hi,
You have right, I will fix that and give You know.
Thanks for review.

Also available in: Atom PDF