ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Extra lines in view section of the respository (Bug #938)

Added by Kranti Konganti at 2012-03-20 03:07 am. Updated at 2012-03-28 08:03 am.

Status:Open Start date:2012-03-20
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:-
Target version:-
Remote issue URL: Affected version:

Description

Hi, I recently upgraded from chiliproject v2.6.X to v3.0.0. Everything seems to work nicely, except when viewing code in the repository.
There seems to be an extra line between each line of code. Also, I use redmine_repo_pygments for syntax highlighting. This plugin worked perfectly with my v2.6.X install with some minor modifications to _file.rhtml and annotate.rhtml files.

In _file.rhtml, this line

<% syntax_highlight(filename, to_utf8(content)).each_line do |line| %>

was changed to
<% syntax_highlight(filename, to_utf8_for_attachments(content)).each_line do |line| %>

and in annotate.rhtml, 

<% syntax_highlight(@path, to_utf8(@annotate.content)).each_line do |line| %>

was changed to 
<% syntax_highlight(@path, to_utf8_for_repositories(@annotate.content)).each_line do |line| %>

Although the core _file.rhtml and annotate.rhtml in v3.0.0 comes with these changes, I still see the extra lines.

Screen_Shot_2012-03-19_at_9.57.00_PM.png - Screenshot showing extra line between code (36 kB) Kranti Konganti, 2012-03-20 03:07 am

History

#1
Updated by Kranti Konganti at 2012-03-20 03:08 am

  • Target version set to 3.1.0
  • Assignee set to Eric Davis

#2
Updated by Holger Just at 2012-03-20 08:21 am

Please assign neither a target version nor an assignee as we use it to track who committed himself to handle an issue for which version.

  • Target version deleted (3.1.0)
  • Assignee deleted (Eric Davis)

#3
Updated by Robert Mitwicki at 2012-03-28 08:03 am

hi,

As I see You use plugin code_review, right?
Because after adding this plugin I've got the same problem.
And solution for that is to change css style:

application.css:1636

#content table.issues td, #content table th {
    border:1px solid #e6e6e6;
    padding: 6px;
    text-align:left;
    position:relative;
    vertical-align:top;
}

exactly padding from 6px to 1px for example as I did.
can someone from core dev could confirm that it could be added as fix for this issue?
In my opinion with 1px is ok.

Also available in: Atom PDF