ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Incorrect error message text for groups (Bug #873)


Added by John Parker at 2012-02-07 11:29 pm. Updated at 2012-03-28 06:57 am.


Status:Closed Start date:2012-02-07
Priority:Low Due date:
Assignee:Felix Schäfer % Done:

0%

Category:User interface
Target version:3.1.0
Remote issue URL: Affected version:3.0.0

Description

The following is displayed when adding a group name greater than 30 characters long.

Last name is too long (maximum is 30 characters)


Associated revisions

Revision c6af5c79
Added by Robert Mitwicki at 2012-03-28 08:56 am

Correct error message on group name #873

History

Updated by Tom Rochette at 2012-02-08 06:24 am

I confirm the message is incorrect.

Repro step:

1. Go to the Groups page in the administration section
2. Click on New group
3. Type in a group name longer than 30 characters.

Result: Incorrect error message Last name is too long (maximum is 30 characters) is displayed.

This is a side-effect of using the lastname variable in app/models/group.rb which inherits from Principal (problematic Liskov substitution).

Updated by John Yani at 2012-02-16 07:11 pm

Is 3.0.0 released or not? Why is this issue still open?

Updated by Holger Just at 2012-02-16 07:21 pm

  • Target version deleted (3.0.0)
  • Affected version set to 3.0.0

Updated by Robert Mitwicki at 2012-03-23 09:06 am

Hi,

I fix that problem and I add test for that:

https://github.com/mitfik/chiliproject/commit/efd0b1dec91c820bd70c4085d6e9ef63dd76dcdc

is waiting in pull request:
https://github.com/chiliproject/chiliproject/pull/167

P.S. I just add this fix to existing pull request, give me know if that is ok.

  • Status changed from Open to Ready for review

Updated by Robert Mitwicki at 2012-03-26 07:18 am

I moved fix to separate branch as is should be:

https://github.com/chiliproject/chiliproject/pull/175

Updated by Felix Schäfer at 2012-03-27 11:08 am

See the 2 comments on GitHub.

  • Assignee set to Felix Schäfer

Updated by Felix Schäfer at 2012-03-28 06:57 am

Reworked, squashed and committed in c6af5c7, thanks!

  • Target version set to 3.1.0
  • Status changed from Ready for review to Closed

Also available in: Atom PDF