Apply Filter does not work on all-project-activities view (Bug #861)

I can't reproduce it on neither demo.chiliproject.org, nor a 2.6.0 instance nor chiliproject.org. It all works as expected.

The activities filter works so that you only see the activity types you select there. What might be surprising is that the labels are actually links so that you can easily select a single activity type.

well for 2.6.0, its tricky:
- it will work for the global actiivities, but not for acitivities for projects with subprojects

(someone should lower the priority to normal or less :) )

Actually, the "wrong" parameter you call with_subprojects is correct :) . The state of the with_subprojects is defined by the checkbox and a hidden field (0 value).

The problem that you encounter has to do with the facts that your activity score parameter hash is empty, thus selecting al available event types again. Could you like try and select the "wiki edits" and deselect your "issues" . You'll see that it will hide all the issues.

Located the problem, but I'll like to talk about it with one of the core developers.

The issue is situated in the activities_controller line 36:

@activity.scope = (@author.nil? ? :default : :all) if @activity.scope.empty?

Here you say that the activie scope has to be filled with default checkboxes or all (depending on user) if the scope is empty. So this means, if you uncheck all the event types, it will automatically fill it again with some default values.

So in the case of E M, who has 3 event types: issues, wiki edit and spent time. wiki edit and spint time are by default deselected. When he unchecks issues ( then you would think no activities would be displayed) his event activities has is empty so the system falls back on the defaults, hence showing the issues again.

Best way would be to check if the subproject param has been submitted or not to see if it as a user submission filter or the starting page request. I'll try to fix this and make a pull request

Ok, made a pull request: [[https://github.com/chiliproject/chiliproject/pull/159]]

Added an extra hidden field so Chiliproject can see that it has to display an empty result set instead of the default filter that is automatically requested on the initial page load.

An alternative variant could be to use a set_filter field, as we don now with issues.

 1diff --git a/app/controllers/activities_controller.rb b/app/controllers/activities_controller.rb
 2index cfc2be4..66b6fcc 100644
 3--- a/app/controllers/activities_controller.rb
 4+++ b/app/controllers/activities_controller.rb
 5@@ -33,7 +33,7 @@ class ActivitiesController < ApplicationController
 6                                                              :with_subprojects => @with_subprojects,
 7                                                              :author => @author)
 8     @activity.scope_select {|t| !params["show_#{t}"].nil?}
 9-    @activity.scope = (@author.nil? ? :default : :all) if @activity.scope.empty?
10+    @activity.scope = (@author.nil? ? :default : :all) if @activity.scope.empty? unless params[:set_filter] == "1" 
11
12     events = @activity.events(@date_from, @date_to)
13
14diff --git a/app/views/activities/index.html.erb b/app/views/activities/index.html.erb
15index 173b750..4d9c4b0 100644
16--- a/app/views/activities/index.html.erb
17+++ b/app/views/activities/index.html.erb
18@@ -42,7 +42,8 @@
19 <% content_for :sidebar do %>
20 <% form_tag({}, :method => :get) do %>
21 <h3><%= l(:label_activity) %></h3>
22-<p><% @activity.event_types.each do |t| %>
23+<% hidden_field_tag "set_filter", 1, :id => nil %>
24+<p><% @activity.event_types.each do |t| %><%= hidden_field_tag "show_#{t}", 0, :id => nil%>
25 <%= check_box_tag "show_#{t}", 1, @activity.scope.include?(t) %>
26 <label for="show_<%=t%>"><%= link_to(l("label_#{t.singularize}_plural"), {"show_#{t}" => 1, :user_id => params[:user_id]})%></label>
27 <br />