ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Link parsing is broken (Bug #553)


Added by Tom Rochette at 2011-07-31 01:15 pm. Updated at 2011-08-09 01:32 am.


Status:Open Start date:2011-07-31
Priority:Normal Due date:
Assignee:- % Done:

0%

Category:-
Target version:-
Remote issue URL: Affected version:

Description

While commenting on an issue, I noticed that the converted URL was wrong.

What I wrote (and expect):

"#87":https://github.com/chiliproject/chiliproject/pull/87

What I see (as the URL):
#87

https://www.chiliproject.org/issues/87


History

Updated by Nick Peelman at 2011-08-08 10:04 pm

I guess one could argue that this is "broken", but as it is, its a problem easily remedied:

"!#87":https://github.com/chiliproject/chiliproject/pull/87

which makes:

#87

Should the link parser be smarter about that? Maybe. Regardless I'd be weary to say that its broken. Its doing what it should be doing, linking unescaped stuff.

Updated by Tom Rochette at 2011-08-09 01:04 am

I'd agree that terminology I used might be wrong.

What I expected was that any string in "here" would be the actual string rendered and that the link after the : would be the link provided/used (escaped if needed). In this case, the first part is correct, while the second isn't working as expected, that is, I'm given a local link instead of the link provided.

Updated by Nick Peelman at 2011-08-09 01:32 am

Tom Rochette wrote:

I'd agree that terminology I used might be wrong.

What I expected was that any string in "here" would be the actual string rendered and that the link after the : would be the link provided/used (escaped if needed). In this case, the first part is correct, while the second isn't working as expected, that is, I'm given a local link instead of the link provided.

Actually if you check out the code, you'll see that you're being given BOTH. The external link is getting generated, if you click on the external link icon the external link still functions. That said, it might merit a change to a regular expression somewhere, but I haven't been able to identify where yet. Perhaps somebody with a little more experience tooling with the auto-link code will have more luck.

Also available in: Atom PDF