ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Issue Journal replies get ignored (Bug #480)

Added by Ryan Briones at 2011-06-16 10:49 pm. Updated at 2011-06-17 07:12 pm.

Status:Closed Start date:2011-06-16
Priority:Normal Due date:
Assignee:Eric Davis % Done:

0%
Category:Journals / History
Target version:2.0.0
Remote issue URL: Affected version:unstable

Description

I'm using RC1 in an installation and I'm running into an issue on Issue replies. I set up a bunch of debugging statements and found out here the klass from the incoming message is issue_journal. Since there is no receive_issue_journal_reply method on MailHandler these messages are getting ignored.

It seems possible that this method is supposed to be named receive_issue_journal_reply which is what I did in my instance in order to "temporarily" fix the problem.

Debugging this problem sucked my soul out so I'll take another look at possible patches/test cases in the morning, but I wanted to get some quick feedback.

Associated revisions

Revision 3d164f1d
Added by Eric Davis at 2011-06-17 09:10 pm

[#480] Fix replying to IssueJournals through email

History

#1
Updated by Felix Schäfer at 2011-06-17 08:57 am

Ryan Briones wrote:

Debugging this problem sucked my soul out so I'll take another look at possible patches/test cases in the morning, but I wanted to get some quick feedback.

This is indeed a problem introduced by the migration to the new journaling scheme, thanks for reporting. (and feel free to report early, even before debugging it, we might be able to help ;-) )

Anyway, I might be able to have a look at this later on, be sure to update here if you have another/a better fix.

  • Target version set to 2.0.0
  • Assignee set to Felix Schäfer
  • Category set to Journals / History

#2
Updated by Eric Davis at 2011-06-17 05:53 pm

Felix couldn't get to this so I'll take a look at it.

  • Assignee changed from Felix Schäfer to Eric Davis

#3
Updated by Eric Davis at 2011-06-17 06:29 pm

Figured out what caused this. Someone updated an issue which caused an outbound email to be sent with a message id like the one below:

Message-Id: <chiliproject.issue_journal-1467.20110617112053@example.net>

When replied to, the MailHandler parsed out IssueJournal 1467 which as Ryan Briones says, can't be converted to a method.

I'll figure out the best long term way to handle these and fix the code now.

#4
Updated by Eric Davis at 2011-06-17 07:12 pm

Fixed in 3d164f1 by renaming the receive_journal_reply method. I would like to refactor that and dispatch so journal replies are looked up automatically but it can wait until after 2.0.0

  • (deleted custom field) set to unstable
  • Status changed from Open to Closed

Also available in: Atom PDF