ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Forum thread links not idempotent (Bug #259)


Added by Felix Schäfer at 2011-03-05 08:01 am. Updated at 2011-03-07 11:22 pm.


Status:Open Start date:2011-03-05
Priority:Normal Due date:
Assignee:- % Done:

0%

Category:Forums
Target version:-
Remote issue URL: Affected version:

Description

The current forum links (/boards/1/topics/2) might become invalid if a thread is moved from one forum to another (the preceding link then becomes /boards/2/topics/2). The boards part should not be included in the links.


Related issues

related to Feature #375: Pretty urls for forums Open 2011-05-04

History

Updated by Eric Davis at 2011-03-06 02:30 am

I think the /boards/:board_id should be part of the route because they scope the thread: "this topic is on this board".

Updated by Felix Schäfer at 2011-03-06 07:34 am

Eric Davis wrote:

I think the /boards/:board_id should be part of the route because they scope the thread: "this topic is on this board".

So by the same rationale, the full path should be /projects/:project_id/boards/:board_id/topics/:id? As well as /issues/:id should probably rather be /projects/:project_id/issues/:id ;-) I don't think the scoping of objects should be part of the path if it's not necessary (wiki pages need to be scoped in the project because the path has the name, which is not unique through projects, I'd state the same case if the wiki paths had ids instead of their names in the paths).

Updated by Eric Davis at 2011-03-07 11:22 pm

Felix:

That makes sense, you're right. So should this change the routes for topics then to be /topics/:id? Or should we actually name them /messages/:id since that is the name of the Model and Controller?

Actually I don't like how the boards and topics are using numbers in the url though but that's a separate issue (/boards/1-discuss/topics/42-help-me is much nicer).

Also available in: Atom PDF