ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Allow the loadpaths of themes to be specified in configuration.yml (Feature #230)

Added by Holger Just at 2011-02-27 07:10 pm. Updated at 2011-03-24 09:25 pm.

Status:Closed Start date:2011-02-27
Priority:Normal Due date:
Assignee:Eric Davis % Done:

0%
Category:Themes
Target version:1.2.0
Remote issue URL: Affected version:

Description

Currently, the theme loadpath is hard-coded in source:lib/redmine/themes.rb#L92. This path should be overrideable in configuration.yml and should allow more than one path.

I have code for it that just needs to be extracted.

Associated revisions

Revision 8cfe498b
Added by Holger Just at 2011-03-24 09:46 pm

[#230] Make loadpath of themes configurable

Based on a987b74ed14 by meineerde

History

#1
Updated by Eric Davis at 2011-02-27 08:20 pm

wrote:

This path should be overrideable in configuration.yml and should
allow more than one path.

I have code for it that just needs to be extracted.

How would this work if we convert themes to full plugins?

#2
Updated by Eric Davis at 2011-03-23 12:24 am

Holger:

How is this coming? Is there a branch I can review?

#3
Updated by Holger Just at 2011-03-23 10:00 am

  • Assignee deleted (Holger Just)
  • Status changed from Open to Ready for review

#4
Updated by Eric Davis at 2011-03-23 11:37 pm

Thanks Holger, it looks fine to me with a few comments:

  • the default option is in Theme#theme_paths. Felix has mentioned putting all of the defaults into Configuration instead.
  • quite a bit of whitespace changes, might be good to cherry-pick and `git add -p` so only the code is pulled in. At least until all of the files are line-ending/trimmed.
  • There is a documentation copy and paste error from /files.

If this looks good to everyone else, I'll merge it for the release (and make these minor changes at that time).

  • Category set to Themes

#5
Updated by Eric Davis at 2011-03-24 09:25 pm

Merged to master with a few changes (whitespace and docs). 8cfe498bd60cdb7fab3f953e1e14aed004361856

  • Assignee set to Eric Davis
  • Status changed from Ready for review to Closed

Also available in: Atom PDF