Issues - Hide the File upload section (Feature #149)

Eric Davis wrote:

Felix described almost exactly what I was thinking. Just a simple toggle. Eventually I think it should be for everyplace file uploads are allowed so there is a common user interface across the entire system.

I think they're all generated from the same helper. I'll give it a shot.

Ok, a first try looks like that:

 1diff --git a/app/views/attachments/_form.rhtml b/app/views/attachments/_form.rhtml
 2index 6d387d1..fc31a26 100644
 3--- a/app/views/attachments/_form.rhtml
 4+++ b/app/views/attachments/_form.rhtml
 5@@ -2,7 +2,8 @@
 6 <%= file_field_tag 'attachments[1][file]', :size => 30, :id => nil  -%><label class="inline"><span id="attachment_description_label_content"><%= l(:label_optional_description) %>
 7 </label>
 8 </span>
 9+<%= javascript_tag("$('attachments_fields').hide();") %>
10 <br />
11-<small><%= link_to l(:label_add_another_file), '#', :onclick => 'addFileField(); return false;' %>
12+<small><%= link_to l(:label_add_another_file), '#', :onclick => 'if ($(\'attachments_fields\').visible()) {addFileField();} else {$(\'attachments_fields\').show();}; return false
13 (<%= l(:label_max_size) %>: <%= number_to_human_size(Setting.attachment_max_size.to_i.kilobytes) %>)
14 </small>

That looks a little weird though because of the big empty space between "files" and the link:

So it would need a tad more work to make the link say "add a file" instead of "add another file" the first time it is shown, and the link must get a little nearer the "files" title, or we could just drop it. Matthew, could you give the little cosmetic improvement idea a spin?

New try:

 1diff --git a/app/views/issues/_edit.rhtml b/app/views/issues/_edit.rhtml
 2index ec36b14..b6e5f0b 100644
 3--- a/app/views/issues/_edit.rhtml
 4+++ b/app/views/issues/_edit.rhtml
 5@@ -36,8 +36,12 @@
 6     <%= text_area_tag 'notes', @notes, :cols => 60, :rows => 10, :class => 'wiki-edit' %>
 7     <%= wikitoolbar_for 'notes' %>
 8     <%= call_hook(:view_issues_edit_notes_bottom, { :issue => @issue, :notes => @notes, :form => f }) %>
 9+    </fieldset>
10
11-    <p><%=l(:label_attachment_plural)%><br /><%= render :partial => 'attachments/form' %></p>
12+    <fieldset id="attachments" class="collapsible collapsed"><legend onclick="toggleFieldset(this);"><%=l(:label_attachment_plural)%></legend>
13+      <div style="display: none;">
14+      <%= render :partial => 'attachments/form' %>
15+      </div>
16     </fieldset>
17     </div>
18     

That puts the file upload things in a collapsed fieldset, it looks a little weird though because it only has a top border. I've also tried re-adding the missing borders, but that looks weird when it's collapsed, I'd prefer it with all borders than just the top one though.

The 4 screenshots are: only top border collapsed and open, all borders collapsed and open:

Eric: Works with CSS, just wobbles a bit because it doesn't have a left border when collapsed and a 1px one when open. The pull request is here: https://github.com/chiliproject/chiliproject/pull/2

Felix:

This looks good, I didn't see the wobbling myself. I did reset the font-size on the legend to 1em though, the .collapsible class turned it down to 0.9em. Feel free to merge when you are ready.

https://github.com/edavis10/chiliproject/tree/ticket/master/149-hide-file-upload-section

Eric Davis wrote:

I did reset the font-size on the legend to 1em though, the .collapsible class turned it down to 0.9em. Feel free to merge when you are ready.

Missed that one, thanks. Merged and committed in 887a10ac6001551facf142520456301bfdcbc286