ChiliProject is not maintained anymore. Please be advised that there will be no more updates.
We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.
Various acts_as_journalized bugs plus tests (Bug #1199)
| Status: | Ready for review | Start date: | 2013-01-07 |
|---|---|---|---|
| Priority: | Normal | Due date: | |
| Assignee: |  Felix Schäfer |
% Done: | 0% |
| Category: | Journals / History | ||
| Target version: | - | ||
| Remote issue URL: | Affected version: | master |
Description
It looked like the acts_as_journalized tests were meant to be run as standalone tests, but I couldn't get them to run so I rewrote them to work with rake test:plugins. Along the way I discovered and fixed a few bugs. Some of the tests didn't make much sense and appeared to be leftovers from VestalVersions. Everything about tags, control blocks, and special conditions was removed because I couldn't find any remaining references to them in the actual source. All of the core tests still pass (except the ones that are temporarily broken due to encoding probs in master).
https://github.com/chiliproject/chiliproject/pull/242
The PR contains the fix mentioned in #1198 as well.
Associated revisions
Mercurial adapter improvements (patch #1199 by Pierre Paysant-Le Roux).
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1499 e93f8b46-1217-0410-a6f0-8f06a7374b81
History
Updated by Felix Schäfer at 2013-01-14 02:09 pm
I think most of the tests were leftovers from VestalVersions and were never meant to be run standalone, as most of the features ChiliProject uses are/should be covered by core tests. If this allows us to spin out aaj to a gem so as not to have it a hard part of the core, I'm all for it.
Would you say the test coverage is good enough to use and develop it standalone? Furthermore, would you then be interested participate in or take over the maintenance of aaj?
Updated by Felix Schäfer at 2013-01-14 02:09 pm
- Status changed from Open to Ready for review
- Assignee set to Felix Schäfer
Updated by Greg Thornton at 2013-01-20 12:46 pm
Sorry, for some reason I'm not getting email notifications from cp.org. I'll check my junk folder. Anyway, yes, this gets us closer to a standalone gem. I wouldn't mind maintaining aaj, but let's chat on IRC soon about how best go about that. I'm wondering if gemifying now would make a Rails 3 port slightly more of a headache.
Updated by Felix Schäfer at 2013-01-20 02:04 pm
Greg Thornton wrote:
Anyway, yes, this gets us closer to a standalone gem. I wouldn't mind maintaining aaj, but let's chat on IRC soon about how best go about that. I'm wondering if gemifying now would make a Rails 3 port slightly more of a headache.
It shouldn't make too big a difference. And sure, pop by IRC :-)