Custom style (css) per project (Feature #1017)

Changed the patch - very nasty bug found in such little code: when creating a new project @project is defined, but not @project.identifier. Second try to a patch.

I'm not sure that's something that should go in the core, not in this form anyway. A more idiomatic way would be to add a project-${identifier} to the css classes of the body element, for example in source:/app/helpers/application_helper.rb#L433

Pulling this out of 3.2.0 as it was not fully reviewed on release day.

I was thinking about that a bit and having project identifiers (potentially a list) in css file or filenames would leak information so we'd need to go with the numeric ids.

I was thinking of something like that:

 1diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
 2index 2ecf967..fcebc5d 100644
 3--- a/app/helpers/application_helper.rb
 4+++ b/app/helpers/application_helper.rb
 5@@ -436,6 +436,7 @@ module ApplicationHelper
 6       css << 'theme-' + theme.name
 7     end
 8
 9+    css << 'project-' + @project.id if @project.present?
10     css << 'controller-' + params[:controller] if params[:controller]
11     css << 'action-' + params[:action] if params[:action]
12     css.join(' ')
13

Holger, any comments? If something like that is good with you I'd prepare a pull request.

Fabio, would the proposed solution (adding a class to the body in the form project-my-awesome-project or project-23) work for you? It's a tad more work as you need to create a "full" theme with the added css for the project, but I don't think this should be a problem.

Furthermore: the project-my-awesome-project leaks the identifiers of projects for which you have custom css to the global css file, thus I'd favor project-23, which is a little less "discoverable" for the theme developer as the numerical id of projects isn't used anywhere else (you'd probably have to open a page in the project and inspect the classes of the body) but doesn't leak the identifiers. Fabio, thoughts?

I think the project-id tags would be good - I happen to like the "less info is more" approach. The only worry I have is that blindly adding css tags is a bit of HTML bloat that somehow could be avoided, it could be a configuration check "add project-specific css tags" so that projects that don't have custom templates won't need to add css (...and lookups in the css from the browsers).

Anyhow, I think it would be a good solution.

Fabio Torchetti wrote:

I think the project-id tags would be good - I happen to like the "less info is more" approach. The only worry I have is that blindly adding css tags is a bit of HTML bloat that somehow could be avoided, it could be a configuration check "add project-specific css tags" so that projects that don't have custom templates won't need to add css (...and lookups in the css from the browsers).

Thanks for the feedback. Regarding a config option: the point of having it as a body class was to reduce complexity, a config option would make it complicated again :-) As for html bloat, as long as it's not a problem I won't worry too much about it.

This solution is probably not the "bestest" possible, but it's available now, we still can improve on it down the road :-)

Committed in 2f21522.