Hi,

I'm currently already using the redmine plugin "redmine_code_review" -> with version 0.4.1 and the current HEAD revision 0.4.4 from https://bitbucket.org/haru_iida/redmine_code_review

My current ChiliProject versions I tested the plugin with are 2.2.1 and 2.3.0.

Currently I didn't notice any bugs.

Did you try the plugin already? If you need help, just ask here - I'll try to answer your questions.

ciao,
Chris

hi,

when I installed the plugin, and activated it on a project, I get the message below in the production log:

ActionView::TemplateError (undefined method `delete' for 1:Fixnum) on line #86 of vendor/plugins/haru_iida-redmine_code_review-0.4.3/app/views/code_review_settings/_show.html.erb:
83: 
84:       <p>
85:         <label><%=h l(:label_if_revision_has_issues)%>:</label>
86:         <%= f.radio_button(:auto_relation, CodeReviewProjectSetting::AUTORELATION_TYPE_RELATES) %>
87:         <%=h l(:label_review_issue_relates) %>
88: 
89:         <%= f.radio_button(:auto_relation, CodeReviewProjectSetting::AUTORELATION_TYPE_BLOCKS) %>

    lib/tabular_form_builder.rb:39:in `label_for_field'
    lib/tabular_form_builder.rb:31:in `radio_button'
    vendor/plugins/haru_iida-redmine_code_review-0.4.3/app/views/code_review_settings/_show.html.erb:86:in `block in _run_erb_vendor47plugins47haru_iida45redmine_code_review45046446347app47views47code_review_settings47_show46html46erb_locals_object_show_tab'
    app/helpers/application_helper.rb:768:in `labelled_tabular_form_for'
    vendor/plugins/haru_iida-redmine_code_review-0.4.3/app/views/code_review_settings/_show.html.erb:66
    app/views/common/_tabs.rhtml:24:in `block in _run_rhtml_app47views47common47_tabs46rhtml_locals_object_tabs'
    app/views/common/_tabs.rhtml:23:in `each'
    app/views/common/_tabs.rhtml:23:in `_run_rhtml_app47views47common47_tabs46rhtml_locals_object_tabs'
    app/helpers/application_helper.rb:219:in `render_tabs'
    app/views/projects/settings.rhtml:3:in `_run_rhtml_app47views47projects47settings46rhtml'
    <internal:prelude>:10:in `synchronize'
    thin (1.2.11) lib/thin/connection.rb:84:in `block in pre_process'
    thin (1.2.11) lib/thin/connection.rb:82:in `catch'
    thin (1.2.11) lib/thin/connection.rb:82:in `pre_process'
    thin (1.2.11) lib/thin/connection.rb:57:in `process'
    thin (1.2.11) lib/thin/connection.rb:42:in `receive_data'
    eventmachine (0.12.10) lib/eventmachine.rb:256:in `run_machine'
    eventmachine (0.12.10) lib/eventmachine.rb:256:in `run'
    thin (1.2.11) lib/thin/backends/base.rb:61:in `start'
    thin (1.2.11) lib/thin/server.rb:159:in `start'
    thin (1.2.11) lib/thin/controllers/controller.rb:86:in `start'
    thin (1.2.11) lib/thin/runner.rb:185:in `run_command'
    thin (1.2.11) lib/thin/runner.rb:151:in `run!'
    thin (1.2.11) bin/thin:6:in `<top (required)>'
    /usr/local/bin/thin:19:in `load'
    /usr/local/bin/thin:19:in `<main>'

Rendering /opt/chiliproject/public/500.html (500 Internal Server Error)

Hi,

I tested the 0.4.4 version and currently can even activate the plugin for all of my projects, but expected a crash when saving a new code review (when annotating a source file).

• new CodeReview ticket was created successfully, regardless of the ocrurred "Internal Error"
• annotated source lines contain a "Review" icon which opens a small window containing another "Internal Error"

So it seems that it'll be a little bit more work to do to get this plugin running with ChiliProject, due to the growing code incompatibilities of Redmine and CP :-(

Sorry, that I currently can't help you further...

Chris

Ok,

thanks anyway, going to turn it off for now as it only was a nice to have

WB.

It's a pity that it doesn't work - I need the review functionality, too :-(

As far as I got some time I'll try to debug that (even if I'm not a Ruby programmer (yet))...

Maybe we get that plugin running...

ciao,
Chris