Hi,

you're right - seems to be a missing handling for the size tag:

!{width=32px;height=64px}images/foo.png!
!{width=50%}images/foo.png!

Currently the support for image height is commented out / incomplete - see:

lib/redcloth3.rb line 945

    def inline_textile_image( text )
        text.gsub!( IMAGE_RE )  do |m|
            stln,algn,atts,url,title,href,href_a1,href_a2 = $~[1..8]
            htmlesc title
            atts = pba( atts )
            atts = " src=\"#{ htmlesc url.dup }\"#{ atts }" 
            atts << " title=\"#{ title }\"" if title
            atts << " alt=\"#{ title }\"" 
            #size = @getimagesize($url);
            #if($size) $atts.= " $size[3]";

The function getimagesize() seems to be missing and should have the task to evaluate the {width:xxx} part of the URL.

=> after a look into Redmine sources, the both lines are disabled there, too... so the error is a layer below that...

The next step would be to open an issue ticket so Felix or Holger can check and possibly solve that...

Or can I port it back from Redmine to CP? (With some hints I can do that maybe even with my noob-skills in Ruby?) ;-)

ciao,
Chris

Thank, you Chris for the fast reply.

I checked the code between redmine and chilliproject.
In this section has red mine the same comments.
So the solution should be at another place.

But i think in the moment, that the other changes in lib/redcloth3.rb may be a solution.
I will check this on the coming weekend, when no production runs on the server.

ciao
Dirk

Textile optionally supports arbitrary CSS, this has security implications though and could lead to XSS attacks, thus it is disabled in ChiliProject. IIRC it's just a switch to flip to get it back, I can't remember off the top of my head where it is though.

problem solved!

I'v updated the lib/redcloth3.rb with the version distributed by redmine 2.2.3.

And i'v disabled the style filtering by change in lib/redmine/wiki_formatting/textile/formatter.rb line 30 from true to false.

 1#-- encoding: UTF-8
 2#-- copyright
 3# ChiliProject is a project management system.
 4#
 5# Copyright (C) 2010-2012 the ChiliProject Team
 6#
 7# This program is free software; you can redistribute it and/or
 8# modify it under the terms of the GNU General Public License
 9# as published by the Free Software Foundation; either version 2
10# of the License, or (at your option) any later version.
11#
12# See doc/COPYRIGHT.rdoc for more details.
13#++
14
15require 'redcloth3'
16
17module Redmine
18  module WikiFormatting
19    module Textile
20      class Formatter < RedCloth3
21        include ActionView::Helpers::TagHelper
22
23        # auto_link rule after textile rules so that it doesn't break !image_url! tags
24        RULES = [:textile, :block_markdown_rule, :inline_auto_link, :inline_auto_mailto]
25
26        def initialize(*args)
27          super
28          self.hard_breaks=true
29          self.no_span_caps=true
30          self.filter_styles=false # false activates the styles in wiki formatting 
31        end
32
33        def to_html(*rules)
34          @toc = []
35          super(*RULES).to_s
36        end

But the is an tiny bug in combination with tables, if you embed the image in an table.
Than all scales below 100% produces thumbnails.