ChiliProject is not maintained anymore. Please be advised that there will be no more updates.
We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.
The "Watcher" filter should show all users. (Feature #566)
| Status: | Closed | Start date: | 2011-08-07 |
|---|---|---|---|
| Priority: | Normal | Due date: | |
| Assignee: | Felix Schäfer |
% Done: | 0% |
| Category: | Issue tracking | ||
| Target version: | 2.3.0 | ||
| Remote issue URL: | Affected version: | master |
Description
Currently, the watcher filter only has the option "me" despite there being a permission "view issue watchers".
I have a patch that populates the watcher filter with the same users as the other user-based filters if the user has the "view issue watchers" permission in at least one project, and adds a restriction to only the projects the user has the "view issue watchers" permission on, except when the only watcher selected is "me".
I'll see if I can tweak the query a little more to include the issues the user watches in projects he doesn't have the "view issue watchers" permission on when he selects other users as well.
Associated revisions
Allow to filter watchers by more than just "me". #566
History
Updated by Felix Schäfer at 2011-08-07 03:28 pm
I'll try to get this done for 2.2.0.
- Target version set to 2.2.0
- (deleted custom field) set to master
Updated by Felix Schäfer at 2011-08-09 01:01 pm
The code is in this branch on GitHub. No tests yet as my setup seems to not like the core tests…
- Assignee deleted (
Felix Schäfer) - Status changed from Open to Ready for review
Updated by Holger Just at 2011-08-27 03:31 pm
Moving this to 2.3 as it still feels unfinished.
- Target version changed from 2.2.0 to 2.3.0
Updated by Felix Schäfer at 2011-10-03 08:01 am
I've added some tests for the filling of the filter so that there's no "obvious" leakage of private data, I don't trust the current style of the filter tests though so I didn't add any to not create any (imo) false sense of tested- and thus correctness.
The pull request is 104 on GitHub, I'm comfortable merging it but would like a second opinion before doing so.
Updated by Holger Just at 2011-10-04 08:10 am
/me hates fixtures. And the queries code doesn't become more beautiful (but TBH, I think it must be killed with fire anyhow by now)
That said I think the patch is good for now :)
Updated by Holger Just at 2011-10-04 08:30 am
Pushed to master
- Assignee set to Felix Schäfer
- Status changed from Ready for review to Closed