ChiliProject is not maintained anymore. Please be advised that there will be no more updates.
We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.
Remove explicit render from WikiController#show (Bug #423)
| Status: | Closed | Start date: | 2011-05-20 |
|---|---|---|---|
| Priority: | Normal | Due date: | |
| Assignee: |  Eric Davis |
% Done: | 0% |
| Category: | Refactoring | ||
| Target version: | 2.0.0 | ||
| Remote issue URL: | Affected version: | unstable |
Description
Removing the explicit render :action => 'show' in WikiController#show will not effect existing functionality but will allow sub-classes of the controller to handle various render formats using a respond_to block. An example of what this will allow is for a gem to add support for additional formats (such as PDF) for a wiki page without affecting existing routes.
I have made a pull request with the changes here
Associated revisions
- overall activity view and feed added, link is available on the project list (#423, #494)
- switch added on the project activity view to include subprojects (closes #530)
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1227 e93f8b46-1217-0410-a6f0-8f06a7374b81
[#423] Removed explicit render in WikiController#show
- Allows for format extensions in plugins w/o giving a double-render
error - Updated Wiki#show template to specify 'wiki/sidebar' explicitly
(vs. just 'sidebar')
History
Updated by Eric Davis at 2011-05-27 03:09 pm
Tom:
Is this ready? I heard you and Holger chatting about it and wasn't sure if this is the final result.
- Status changed from Open to Needs more information
Updated by Tom Kersten at 2011-05-27 03:13 pm
Eric:
As far as I know, it is ready to go. I have applied the patch locally and in our production site with no impact. I believe the only task remaining was to create this ticket so any necessary future discussions could use it as a reference.
Updated by Eric Davis at 2011-05-27 05:06 pm
Thanks. We might be able to include it into 2.0.0.
- Target version set to 2.0.0
- Category set to Refactoring
- Status changed from Needs more information to Ready for review
Updated by Tom Kersten at 2011-05-27 05:21 pm
Cool. Let me know if there is anything you'd like to see me do on my end to make it easier on yours.
Updated by Eric Davis at 2011-05-27 05:34 pm
Tom Kersten wrote:
Let me know if there is anything you'd like to see me do on my end to make it easier on yours.
Only thing I saw was that if you prefix the commit log with an issue, it helps us associate the commit to the issue. I added some examples to Git Standards.
Added to unstable in ce8bb652c6e7. Thanks for the patch and let us know if you come across any other refactorings.
- Assignee set to Eric Davis
- (deleted custom field) set to unstable
- Status changed from Ready for review to Closed
Updated by Tom Kersten at 2011-05-27 05:41 pm
Got it. Will do...and thanks for merging it in!