ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Review and fix the Activity event types (Bug #400)

Added by Eric Davis at 2011-05-13 06:01 pm. Updated at 2011-05-20 09:24 pm.

Status:Closed Start date:2011-05-13
Priority:Normal Due date:
Assignee:Felix Schäfer % Done:

0%
Category:Journals / History
Target version:2.0.0
Remote issue URL: Affected version:unstable

Description

From Felix on #123

[B] One change I've noticed: the event types (used to display the icons on the activity list) are now object- and not event/journal-bound (a closed issue will return the issue-closed type for all its events, including past ones in which the issue was still open) and some are missing (issue-note/"a new issue note without issue edit" and issue-edit/"an issue edit" at least).

Related issues

related to Feature #123: Review and Merge acts_as_journalized Closed 2011-02-02

Associated revisions

Revision 66561031
Added by Felix Schäfer at 2011-05-20 10:51 pm

[#400] Fix the event types (icons on activity and search views).

Revision a4f7629f
Added by Eric Davis at 2011-05-20 11:22 pm

[#400] Fix some tests broken by 6656103

Revision 078df723
Added by Eric Davis at 2011-05-20 11:23 pm

[#400] Refactor old assert_tag to assert_select

History

#1
Updated by Felix Schäfer at 2011-05-13 10:54 pm

https://github.com/finnlabs/chiliproject/commit/6131df3935cae773c9495c39519f7f5edec6683e fixes this, it has 2 parts:

  • the change in acts_as_journalized.rb restores the event_type to the journalized model, not the journal model associated to it (as aaj calls acts_as_event, the later would recognize the ModelJournal model as being the event, not the Model itself, hence the explicit default in aaj),
  • the change in app/models/issue.rb restores the previous behavior of:
    • on issue note without editing the issue metadata, the event type is issue-note,
    • on issue edit without a change to a closed status, the event type is issue-edit,
    • on issue edit with a change to a closed status, the event type is issue-closed,
    • else the event type is issue.

(please note that this is not exactly the previous behavior, as the previous behavior was the event type set to issue for all issue events (i.e. non note or metadata edit event, meaning the creation event) when the issue is still open an issue-closed on all issue events when the issue is closed)

  • Target version set to 2.0.0

#2
Updated by Felix Schäfer at 2011-05-19 09:43 pm

This is ready for review.

  • Status changed from Open to Ready for review

#3
Updated by Eric Davis at 2011-05-20 03:47 pm

Felix Schäfer wrote:

(please note that this is not exactly the previous behavior, as the previous behavior was the event type set to issue for all issue events (i.e. non note or metadata edit event, meaning the creation event) when the issue is still open an issue-closed on all issue events when the issue is closed)

I think this is a better behavior. The activity page was difficult to use in order to see what types of changes happened. By separating them out into more options, hopefully it will be clearer.

I'll see if I can review it today.

#4
Updated by Eric Davis at 2011-05-20 09:24 pm

Merged along with some test fixes in 6e105a7

  • Assignee set to Felix Schäfer
  • Status changed from Ready for review to Closed

Also available in: Atom PDF