ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Fix broken tests in unstable caused by conflicting to_utf8 method names (Bug #383)

Added by Eric Davis at 2011-05-06 11:01 pm. Updated at 2011-06-17 09:38 pm.

Status:Closed Start date:2011-05-06
Priority:High Due date:
Assignee:Eric Davis % Done:

0%
Category:Testing
Target version:2.0.0
Remote issue URL: Affected version:unstable

Description

A few of the tests are failing in unstable. The reason is because several helpers all define the same to_utf8 method but with slightly different method bodies.

Associated revisions

Revision 13de4cc4
Added by Eric Davis at 2011-05-07 01:38 am

[#383] Fixed failing tests due to a helper method name conflict (to_utf8)

Introduced in 1eee7312f60267b0f8e575cc96302812f2dc38a8

Revision 9f2c412f
Added by Eric Davis at 2011-06-17 11:36 pm

[#383] Fix for undefined_method 'to_utf8'

Contributed by Artem Naluzhnyy

History

#1
Updated by Eric Davis at 2011-05-06 11:39 pm

Fixed in 13de4cc

  • Status changed from Open to Closed

#2
Updated by Artem Naluzhnyy at 2011-06-11 04:51 pm

Looks like you missed several to_utf8 calls in app/views/common/_diff.rhtml.

Patch to fix appropriate undefined method `to_utf8' errors: 

--- _diff.rhtml.orig 2011-06-10 23:36:19.000000000 +0300
+++ _diff.rhtml 2011-06-11 19:39:59.000000000 +0300
@@ -5,7 +5,7 @@
 <% if diff.diff_type == 'sbs' -%>
 <table class="filecontent">
 <thead>
-<tr><th colspan="4" class="filename"><%=to_utf8 table_file.file_name %></th></tr>
+<tr><th colspan="4" class="filename"><%=to_utf8_for_attachments table_file.file_name %></th></tr>
 </thead>
 <tbody>
 <% table_file.each_line do |spacing, line| -%>
@@ -17,11 +17,11 @@
 <tr>
   <th class="line-num"><%= line.nb_line_left %></th>
   <td class="line-code <%= line.type_diff_left %>">
-    <pre><%=to_utf8 line.html_line_left %></pre>
+    <pre><%=to_utf8_for_attachments line.html_line_left %></pre>
   </td>
   <th class="line-num"><%= line.nb_line_right %></th>
   <td class="line-code <%= line.type_diff_right %>">
-    <pre><%=to_utf8 line.html_line_right %></pre>
+    <pre><%=to_utf8_for_attachments line.html_line_right %></pre>
   </td>
 </tr>
 <% end -%>

  • Status changed from Closed to Open

#3
Updated by Eric Davis at 2011-06-17 09:38 pm

Thanks, fixed in 9f2c412

  • Subject changed from Fix broken tests in unstable to Fix broken tests in unstable caused by conflicting to_utf8 method names
  • Status changed from Open to Closed

Also available in: Atom PDF